[libcxx-commits] [PATCH] D89013: [libcxx] Support per-target __config_site in per-target runtime build
Petr Hosek via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 31 15:25:01 PDT 2021
phosek added inline comments.
Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:379
+ // Second add the generic one.
> Doesn't that break `#include_next` if both directories exist? Generally speaking, I think you only ever want to have a single directory containing the libc++ headers on your header search path.
See my comment, the per-target include path will only contain `__config_site` whereas the generic one contains all the headers other than `__config_site` so this works fine. It would even work if you had another copy of `__config_site` in the generic one which may be useful on platforms that don't currently support the multiarch layout like Darwin.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits