[libcxx-commits] [PATCH] D99104: [libcxx] renames and moves all concept tests

Christopher Di Bella via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Mar 23 13:46:56 PDT 2021


cjdb added inline comments.


================
Comment at: libcxx/test/std/concepts/concepts.callable/concept.regularinvocable/regular_invocable.pass.cpp:20
 
-#include "functions.h"
+#include "../functions.h"
 
----------------
zoecarver wrote:
> What do you think about doing this in two patches?
>   1. rename `.compile.pass.cpp` -> `.pass.cpp`.
>   2. move around the location in tree/rename files.
What's the motivation? I'm not against it, just want to make sure the effort is justified.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99104/new/

https://reviews.llvm.org/D99104



More information about the libcxx-commits mailing list