[libcxx-commits] [PATCH] D99104: [libcxx] renames and moves all concept tests

[Casey Carter via Phabricator via libcxx-commits]

CaseyCarter added a comment.

In D99104#2642503 <https://reviews.llvm.org/D99104#2642503>, @ldionne wrote:

> I must admit I agree with @EricWF's comment about `.compile.pass.cpp` tests potentially causing runtime tests to be skipped.

FWIW, we use a convention that `main` in a compile-only test is annotated (`int main() {} // COMPILE-ONLY`) to avoid such problems. This convention predates us actually having technology in our test runners to support compile-only tests, or we'd probably be using the superior `int main() { return 1; } // COMPILE-ONLY`. (Hmmm, I may go make a PR for that change right now.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99104/new/

https://reviews.llvm.org/D99104