[libcxx-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data
David Zarzycki via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 10 04:23:27 PST 2021
davezarzycki updated this revision to Diff 329613.
davezarzycki added a comment.
I believe I have addressed all of the feedback to date.
For people that care about easily identifying the failures from the previous testing run, that is now encoded via the sign of the test time (please remember that negative test times are impossible). For example:
I've also implemented but commented out how one might use this to implement `--only-failures`. Feedback would be appreciated but I don't want to derail this change proposal on what should be an independent change.
Finally, python is not my native programming language, so thank you for helping me with idiomatic changes. What I'd really like help with though is figuring out a way to not pass the prior test timing data down as a new parameter to various methods. I tried to hang the data off the test suite data structure but that had brutal performance side effects. It seemed like python was hammering on the global interpreter lock despite the prior timing data being unused after the sorting phase. Weird. Help would be greatly appreciated. Thanks!
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 21262 bytes
Desc: not available
More information about the libcxx-commits