[libcxx-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data
James Henderson via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Wed Mar 10 05:45:06 PST 2021
jhenderson added a comment.
I've skimmed the implementation, and it looks good to me, but I haven't got the time right now to review thoroughly. I'm pleased to see the ease of implementing "only-failures" on top of this too, thanks for illustrating.
Comment at: llvm/utils/lit/lit/main.py:275
+ path = os.path.join(s, '.lit_test_times.txt')
+ with open(path, 'w') as file:
+ for name, time in value:
`file` is a builtin python type, so don't use it as a variable name. Just call it `time_file` or something like that.
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
More information about the libcxx-commits