[libcxx-commits] [PATCH] D98166: [libcxx] Test accessing a directory on windows that gives "access denied" errors

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo created this revision.
mstorsjo added a reviewer: curdeius.
mstorsjo requested review of this revision.
Herald added a project: libc++.
Herald added a reviewer: libc++.

Fix handling of skip_permission_denied on windows; after converting
the return value of GetLastError() to a standard error_code, ec.value()
is in the standard errc range, not a native windows error code. This
was missed in 156180727d6c347eda3ba749730707acb8a48093 <https://reviews.llvm.org/rG156180727d6c347eda3ba749730707acb8a48093>.

The directory "C:\System Volume Information" does seem to exist and
have these properties, but try to verify its existence first.

I guess one could/should factor out the initial setup code to a helper
in support/filesystem_test_helper.h. @curdeius, WDYT?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D98166

Files:
  libcxx/src/filesystem/directory_iterator.cpp
  libcxx/test/std/input.output/filesystems/class.directory_entry/directory_entry.cons/path.pass.cpp
  libcxx/test/std/input.output/filesystems/class.directory_iterator/directory_iterator.members/ctor.pass.cpp
  libcxx/test/std/input.output/filesystems/class.rec.dir.itr/rec.dir.itr.members/ctor.pass.cpp
  libcxx/test/std/input.output/filesystems/fs.op.funcs/fs.op.exists/exists.pass.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D98166.328956.patch
Type: text/x-patch
Size: 6781 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20210308/fdf16986/attachment.bin>