[libcxx-commits] [PATCH] D98166: [libcxx] Test accessing a directory on windows that gives "access denied" errors

[Marek Kurdej via Phabricator via libcxx-commits]

curdeius requested changes to this revision.
curdeius added a comment.
This revision now requires changes to proceed.

We certainly need to factor it out into some helper in `support/filesystem_test_helper.h` as you suggested.
Also, I'm not really at ease with:

  if (!found)
    return;

I think that we should check it as a precondition of a test. Just returning if the dir is not found may lead to some stupid errors and dead tests.
Is there any case where this path would be inaccessible? MinGW? I mean apart from having a very old OS or no C: partition?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D98166/new/

https://reviews.llvm.org/D98166