[libcxx-commits] [PATCH] D96408: Fix warnings when compiling libcxx for Windows with clang-cl /W4

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added a comment.

FWIW, when building with CMake, we already do try to add `-Wno-unused-parameter` (which ends up applied also when building with clang-cl), so in that sense these shouldn't be needed when building in such configurations. But if we have a precedent for silencing this kind of unused parameters like this too (which is quite harmless anyway), for silencing them when building libcxx via other custom build systems, then that's certainly good too.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96408/new/

https://reviews.llvm.org/D96408