[libcxx-commits] [PATCH] D104980: [libcxx][NFC] replaces `<utility>` includes with specific headers

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added inline comments.


================
Comment at: libcxx/include/concepts:216
   requires (_Lhs __lhs, _Rhs&& __rhs) {
-    { __lhs = _VSTD::forward<_Rhs>(__rhs) } -> same_as<_Lhs>;
+    { __lhs = static_cast<_Rhs&&>(__rhs) } -> same_as<_Lhs>;
   };
----------------
ldionne wrote:
> Same.. those shouldn't be part of this patch (and if you want to do it throughout in a different patch, let's discuss beforehand).
Hmm... I didn't realise I did it to so many things. I owe @Mordante an apology in that case.

I'll do an audit before uploading a new revision.


================
Comment at: libcxx/include/module.modulemap:716
+      module pair {
+        export __tuple
+        header "__utility/pair.h"
----------------
ldionne wrote:
> What happens if you don't `export __tuple`?
Bad things. Seriously though, it means that whatever standard stuff `pair.h` exports which currently lives in `__tuple` won't be transitively exported. I haven't properly looked into what `__tuple` owns, but there are a few things, and we'll need to detangle them from `tuple`'s dependencies.

Both of those tasks are far lower on my P-list: I'm trying to focus more on improving potential UX for our existing header splices as well as implementing ranges algos.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104980/new/

https://reviews.llvm.org/D104980