[libcxx-commits] [PATCH] D104980: [libcxx][NFC] replaces `<utility>` includes with specific headers

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/include/__functional/identity.h:27
     {
-        return _VSTD::forward<_Tp>(__t);
+        return static_cast<_Tp&&>(__t);
     }
----------------
Same here, this shouldn't be part of this change.


================
Comment at: libcxx/include/concepts:216
   requires (_Lhs __lhs, _Rhs&& __rhs) {
-    { __lhs = _VSTD::forward<_Rhs>(__rhs) } -> same_as<_Lhs>;
+    { __lhs = static_cast<_Rhs&&>(__rhs) } -> same_as<_Lhs>;
   };
----------------
Same.. those shouldn't be part of this patch (and if you want to do it throughout in a different patch, let's discuss beforehand).


================
Comment at: libcxx/include/module.modulemap:716
+      module pair {
+        export __tuple
+        header "__utility/pair.h"
----------------
What happens if you don't `export __tuple`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104980/new/

https://reviews.llvm.org/D104980