[libcxx-commits] [PATCH] D104980: [libcxx][NFC] replaces `<utility>` includes with specific headers

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added inline comments.


================
Comment at: libcxx/include/module.modulemap:716
+      module pair {
+        export __tuple
+        header "__utility/pair.h"
----------------
cjdb wrote:
> ldionne wrote:
> > What happens if you don't `export __tuple`?
> Bad things. Seriously though, it means that whatever standard stuff `pair.h` exports which currently lives in `__tuple` won't be transitively exported. I haven't properly looked into what `__tuple` owns, but there are a few things, and we'll need to detangle them from `tuple`'s dependencies.
> 
> Both of those tasks are far lower on my P-list: I'm trying to focus more on improving potential UX for our existing header splices as well as implementing ranges algos.
@cjdb This sounds like the same issue I have with `<optional>` in `<__format/format_context.h>` (D103357)



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104980/new/

https://reviews.llvm.org/D104980