[libcxx-commits] [PATCH] D115535: [libunwind] Provide a way to conveniently install libunwind headers

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Tue Dec 14 08:10:53 PST 2021


ldionne added inline comments.


================
Comment at: libunwind/include/CMakeLists.txt:19-23
+  install(FILES mach-o/compact_unwind_encoding.h
+    DESTINATION include/mach-o
+    COMPONENT unwind-headers
+    PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ
+  )
----------------
Instead, why don't we simply do

```
set(files
    __libunwind_config.h
    libunwind.h
    mach-o/compact_unwind_encoding.h
    unwind_arm_ehabi.h
    unwind_itanium.h
    unwind.h
    )
```

above and always include that header?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115535/new/

https://reviews.llvm.org/D115535



More information about the libcxx-commits mailing list