[libcxx-commits] [PATCH] D115535: [libunwind] Provide a way to conveniently install libunwind headers

[PoYao Chang via Phabricator via libcxx-commits]

rZhBoYao added inline comments.


================
Comment at: libunwind/include/CMakeLists.txt:19-23
+  install(FILES mach-o/compact_unwind_encoding.h
+    DESTINATION include/mach-o
+    COMPONENT unwind-headers
+    PERMISSIONS OWNER_READ OWNER_WRITE GROUP_READ WORLD_READ
+  )
----------------
ldionne wrote:
> Instead, why don't we simply do
> 
> ```
> set(files
>     __libunwind_config.h
>     libunwind.h
>     mach-o/compact_unwind_encoding.h
>     unwind_arm_ehabi.h
>     unwind_itanium.h
>     unwind.h
>     )
> ```
> 
> above and always include that header?
At first, I actually tried that, only to find out `mach-o/compact_unwind_encoding.h` would then be installed as `<CMAKE_INSTALL_PREFIX>/include/compact_unwind_encoding.h` instead of `<CMAKE_INSTALL_PREFIX>/include/mach-o/compact_unwind_encoding.h`, which I think is undesirable. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115535/new/

https://reviews.llvm.org/D115535