[libcxx-commits] [PATCH] D115535: [libunwind] Provide a way to conveniently install libunwind headers

[PoYao Chang via Phabricator via libcxx-commits]

rZhBoYao added inline comments.


================
Comment at: libunwind/include/CMakeLists.txt:17
+
+if(NOT CMAKE_CONFIGURATION_TYPES AND LIBUNWIND_INSTALL_LIBRARY)
+  add_custom_target(install-unwind-headers
----------------
ldionne wrote:
> Why do we have that check?
Should've been `NOT CMAKE_CONFIGURATION_TYPES AND LIBUNWIND_INSTALL_HEADERS`. That must've slipped in when I cargo-culted it from other cmake file. I believe `NOT CMAKE_CONFIGURATION_TYPES` is meant to hide install-* targets from IDEs, since `CMAKE_CONFIGURATION_TYPES` is set only if the generator is an IDE say -GXcode and not -GNinja. 


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115535/new/

https://reviews.llvm.org/D115535