[libcxx-commits] [PATCH] D108743: [libc++] Revert a use of `static_cast` for `_VSTD::forward`. NFCI

Arthur O'Dwyer via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Thu Aug 26 07:42:37 PDT 2021


Quuxplusone added a comment.

> Can we revert all the functional changes that were made in D107584 <https://reviews.llvm.org/D107584>?

Unfortunately, I'm not aware of any functional changes that were made in D107584 <https://reviews.llvm.org/D107584>. I see a bunch of repetitive comments from Chris on that review, but I don't see what change he's referring to; the left-hand and right-hand sides look the same to me. So I'm not going to pursue this any further. If people want specific changes made, relative to the status quo, I think they should be specific about them.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108743/new/

https://reviews.llvm.org/D108743



More information about the libcxx-commits mailing list