[libcxx-commits] [PATCH] D108743: [libc++] Revert a use of `static_cast` for `_VSTD::forward`. NFCI

[Louis Dionne via Phabricator via libcxx-commits]

ldionne requested changes to this revision.
ldionne added a comment.
This revision now requires changes to proceed.

Can we revert all the functional changes that were made in D107584 <https://reviews.llvm.org/D107584>? It's really a matter of principle - if we start making changes in modularization patches (or any NFCI patch that is large enough to be difficult to audit), we lose an important contract with the reviewer that makes reviewing these patches palatable.

I'm 100% open to reviewing these "functional" changes on their own, but I just can't reasonably review them alongside 1000+ lines of NFC changes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108743/new/

https://reviews.llvm.org/D108743