[libcxx-commits] [PATCH] D108743: [libc++] Revert a use of `static_cast` for `_VSTD::forward`. NFCI

Thu Aug 26 08:26:02 PDT 2021

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

In D108743#2967260 <https://reviews.llvm.org/D108743#2967260>, @Quuxplusone wrote:

>> Can we revert all the functional changes that were made in D107584 <https://reviews.llvm.org/D107584>?
>
> Unfortunately, I'm not aware of any functional changes that were made in D107584 <https://reviews.llvm.org/D107584>. I see a bunch of repetitive comments from Chris on that review, but I don't see what change he's referring to; the left-hand and right-hand sides look the same to me. So I'm not going to pursue this any further. If people want specific changes made, relative to the status quo, I think they should be specific about them.

Oh crap, you're right, the other flagged changes appear to be whitespace changes only. Sorry about that. Please ship this!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108743/new/

https://reviews.llvm.org/D108743