[libcxx-commits] [PATCH] D101547: [libc++] Implement ranges::view

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver added inline comments.


================
Comment at: libcxx/test/std/ranges/range.view/enable_view.compile.pass.cpp:23
+// Doesn't derive from view_base
+struct NotAView1 { };
+static_assert(!std::ranges::enable_view<NotAView1>);
----------------
What if you named these more like the types in the other test file? So this would be `Empty`, next would be `PrivateViewBase`, then `EnableViewFalse`, then `DerivesViewBase`, then `EnableViewTrue` (or something similar). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101547/new/

https://reviews.llvm.org/D101547