[libcxx-commits] [PATCH] D101547: [libc++] Implement ranges::view

[Zoe Carver via Phabricator via libcxx-commits]

zoecarver accepted this revision as: zoecarver.
zoecarver added a comment.

Nice! Looks good sans the nits.



================
Comment at: libcxx/docs/OneRangesProposalStatus.csv:43
 [range.sized],,"[range.primitives], [range.range]",,,
-[range.view],View and enable_view,[range.range],,,
+[range.view],View and enable_view,[range.range],Louis Dionne,,
 [range.refinements],"OutputRange, InputRange, ForwardRange, BidirectionalRange, RandomAccessRange, ContiguousRange, CommonRange, ViewableRange","[ranges.syn]: pt. 2, [range.range]",Christopher Di Bella,"input_range: `D100271 <https://llvm.org/D100271>`_
----------------
Is there anything else here? I think you can mark it as complete. 


================
Comment at: libcxx/include/ranges:62
 #include <__ranges/concepts.h>
-#include <__ranges/end.h>
 #include <__ranges/enable_borrowed_range.h>
----------------
We need to keep this. 


================
Comment at: libcxx/test/std/ranges/range.view/view.compile.pass.cpp:36
+static_assert(std::ranges::enable_view<NotMoveable>);
+  static_assert(!std::ranges::view<NotMoveable>);
+
----------------
Nit: spacing (and elsewhere). 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101547/new/

https://reviews.llvm.org/D101547