[libcxx-commits] [PATCH] D101547: [libc++] Implement ranges::view

[Tim Song via Phabricator via libcxx-commits]

tcanens added inline comments.


================
Comment at: libcxx/test/std/ranges/range.view/view.compile.pass.cpp:27-30
+  friend int* begin(NotMoveable&);
+  friend int* begin(NotMoveable const&);
+  friend int* end(NotMoveable&);
+  friend int* end(NotMoveable const&);
----------------
cjdb wrote:
> ldionne wrote:
> > @cjdb I found it very surprising that I had to provide both those overloads for the `range` concept to be satisfied. Is that really intended, or is that a bug in the patch that adds `range` (which is under review)?
> This is a very annoying artefact of the poison pills. @tcanens, what's the likelihood we can get LWG to review their existence?
Would definitely take a paper and implementation experience.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101547/new/

https://reviews.llvm.org/D101547