[libcxx-commits] [PATCH] D101205: [libcxx] disables ranges for clang-cl

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

In D101205#2714627 <https://reviews.llvm.org/D101205#2714627>, @mstorsjo wrote:

> In D101205#2714595 <https://reviews.llvm.org/D101205#2714595>, @Mordante wrote:
>
>> Wouldn't it be better to properly add a `libcpp-no-ranges` to `utils/libcxx/test/features.py`?
>> I expect the something like this untested code the do the job:
>> `Feature(name='libcpp-no-ranges',  when=lambda cfg: featureTestMacros(cfg).get('__cpp_concepts', 0) < 201907) and _isMSVC and _isClang,`
>
> `... or (_isMSVC and _isClang)` I suppose?

Yes.

>> Then change the test from `// UNSUPPORTED: libcpp-no-concepts` to `// UNSUPPORTED: libcpp-no-ranges` and remove the `XFAIL`s.
>
> I guess that could work too, and would be less clutter. We won't notice when/if it gets fixed then though, but I don't think that's a big deal (as we'll have to minimize the bug and report it, so we'll probably have decent track of when/how it gets fixed anyway).

True, but IMO it gives less clutter. If we want to see when it's fixed we could add a dummy test contain one test that currently fails. This test then uses

  // UNSUPPORTED: libcpp-no-concepts
  // XFAIL: msvc && clang

This test then should also contain coment to update `utils/libcxx/test/features.py`'s `libcpp-no-ranges` lambda, once the test passes.
WDYT?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101205/new/

https://reviews.llvm.org/D101205