[libcxx-commits] [PATCH] D101205: [libcxx] disables ranges for clang-cl
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Sat Apr 24 08:38:49 PDT 2021
mstorsjo added a comment.
In D101205#2714595 <https://reviews.llvm.org/D101205#2714595>, @Mordante wrote:
> Wouldn't it be better to properly add a `libcpp-no-ranges` to `utils/libcxx/test/features.py`?
> I expect the something like this untested code the do the job:
> `Feature(name='libcpp-no-ranges', when=lambda cfg: featureTestMacros(cfg).get('__cpp_concepts', 0) < 201907) and _isMSVC and _isClang,`
`... or (_isMSVC and _isClang)` I suppose?
> Then change the test from `// UNSUPPORTED: libcpp-no-concepts` to `// UNSUPPORTED: libcpp-no-ranges` and remove the `XFAIL`s.
I guess that could work too, and would be less clutter. We won't notice when/if it gets fixed then though, but I don't think that's a big deal (as we'll have to minimize the bug and report it, so we'll probably have decent track of when/how it gets fixed anyway).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101205/new/
https://reviews.llvm.org/D101205
More information about the libcxx-commits
mailing list