[libcxx-commits] [PATCH] D101205: [libcxx] disables ranges for clang-cl

Sat Apr 24 09:53:08 PDT 2021

mstorsjo added a comment.

In D101205#2714635 <https://reviews.llvm.org/D101205#2714635>, @Mordante wrote:

>> I guess that could work too, and would be less clutter. We won't notice when/if it gets fixed then though, but I don't think that's a big deal (as we'll have to minimize the bug and report it, so we'll probably have decent track of when/how it gets fixed anyway).
>
> True, but IMO it gives less clutter. If we want to see when it's fixed we could add a dummy test contain one test that currently fails. This test then uses
>
>   // UNSUPPORTED: libcpp-no-concepts
>   // XFAIL: msvc && clang
>
> This test then should also contain coment to update `utils/libcxx/test/features.py`'s `libcpp-no-ranges` lambda, once the test passes.
> WDYT?

That sounds good to me!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101205/new/

https://reviews.llvm.org/D101205