[libcxx-commits] [PATCH] D101205: [libcxx] disables ranges for clang-cl

Mark de Wever via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Sat Apr 24 08:01:26 PDT 2021


Mordante added a comment.

Wouldn't it be better to properly add a `libcpp-no-ranges` to `utils/libcxx/test/features.py`?
I expect the something like this untested code the do the job:
`Feature(name='libcpp-no-ranges',  when=lambda cfg: featureTestMacros(cfg).get('__cpp_concepts', 0) < 201907) and _isMSVC and _isClang,`

Then change the test from `// UNSUPPORTED: libcpp-no-concepts` to `// UNSUPPORTED: libcpp-no-ranges` and remove the `XFAIL`s.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101205/new/

https://reviews.llvm.org/D101205



More information about the libcxx-commits mailing list