[libcxx-commits] [PATCH] D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons
Arthur O'Dwyer via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Mon Apr 19 09:39:11 PDT 2021
Quuxplusone accepted this revision.
Quuxplusone added a comment.
@Mordante wrote:
> There are still quite some formatting errors, for example `() ,` instead of `(),`, please use the instructions here to format the patch https://llvm.org/docs/Contributing.html#how-to-submit-a-patch
@Mordante: That's intentional; we write `(x , ...)` when we're folding over `operator,`. If clang-format can't tell the difference, that's a bug in clang-format.
(All: Please do //not// blindly clang-format; that just introduces whitespace errors that someone else will have to fix manually down the road.)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D94511/new/
https://reviews.llvm.org/D94511
More information about the libcxx-commits
mailing list