[libcxx-commits] [PATCH] D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons

Mon Apr 19 09:46:15 PDT 2021

kamleshbhalui added a comment.

In D94511#2698813 <https://reviews.llvm.org/D94511#2698813>, @Mordante wrote:

> There are still quite some formatting errors, for example `() ,` instead of `(),`, please use the instructions here to format the patch https://llvm.org/docs/Contributing.html#how-to-submit-a-patch

It's the case for fold expression, and it is done deliberately after @Quuxplusone  suggestions.

> Other than that is seems good now. I still like to see a fresh CI run, to make sure `generate_feature_test_macro_components.py` is updated properly.

ok, will update this.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94511/new/

https://reviews.llvm.org/D94511