[libcxx-commits] [PATCH] D94511: [libc++] [C++20] [P0586] Implement safe integral comparisons

[Mark de Wever via Phabricator via libcxx-commits]

Mordante added a comment.

There are still quite some formatting errors, for example `() ,` instead of `(),`, please use the instructions here to format the patch https://llvm.org/docs/Contributing.html#how-to-submit-a-patch

Other than that is seems good now. I still like to see a fresh CI run, to make sure `generate_feature_test_macro_components.py` is updated properly.



================
Comment at: libcxx/utils/generate_feature_test_macro_components.py:343
     "headers": ["utility"],
-    "unimplemented": True,
+    "test_suite_guard": "!defined(_LIBCPP_HAS_NO_CONCEPTS)",
+    "libcxx_guard": "!defined(_LIBCPP_HAS_NO_CONCEPTS)",
----------------
This should be `"defined(__cpp_concepts) && __cpp_concepts >= 201907L"`, the guard below is correct.
(I'm sure wrote that before, but I can't find it anymore :-()

Make sure to run the script after updating.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D94511/new/

https://reviews.llvm.org/D94511