[libcxx-commits] [PATCH] D96477: [libcxx] adds remaining callable concepts

[Arthur O'Dwyer via Phabricator via libcxx-commits]

Quuxplusone resigned from this revision.
Quuxplusone added a comment.

As I said on Discord, there's nothing here that can't be "fixed in post." We use version control; it's easy to make changes to what's been committed. So since I'm the only one still reviewing this patch, okay, go ahead, I take no further responsibility for its correctness. If @ldionne or anyone else objects to my resigning as reviewer on this revision, they can step in and review it themselves.



================
Comment at: libcxx/test/std/concepts/concepts.callable/concept.equiv/equivalence_relation.subsumption.pass.cpp:22-24
+template<class F, class T>
+requires std::equivalence_relation<F, T, T> && true
+[[nodiscard]] constexpr bool check_subsumption() { return false; }
----------------
cjdb wrote:
> Quuxplusone wrote:
> > This template-of-two-parameters is never used. Please remove it from this patch.
> This was added [[ https://reviews.llvm.org/D96477?id=334360#inline-937744 | at your request ]]. Please confirm you understand what you're asking to be removed (or provide a technical argument explaining why it doesn't meet the conditions of your original request), and I'll remove it between libc++ approval and pushing to main.
Look, you agree that this two-argument function template is never a candidate in any of the calls below, and is therefore useless, right?

And [I did not request](https://reviews.llvm.org/D96477?id=334360#inline-937744) that you add a useless function template that was never a candidate, right? I suggested that you should add a test that "`equivalence_relation<F, T, U>` [subsumes|does not subsume] `equivalence_relation<F, T, T>`." You haven't done that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96477/new/

https://reviews.llvm.org/D96477