[libcxx-commits] [PATCH] D96477: [libcxx] adds remaining callable concepts

[Christopher Di Bella via Phabricator via libcxx-commits]

cjdb added a comment.

This patch has been open for almost two months now, so if there's nothing else that urgently needs attention, I'd like to see it merged today.



================
Comment at: libcxx/test/std/concepts/concepts.callable/concept.equiv/equivalence_relation.subsumption.pass.cpp:22-24
+template<class F, class T>
+requires std::equivalence_relation<F, T, T> && true
+[[nodiscard]] constexpr bool check_subsumption() { return false; }
----------------
Quuxplusone wrote:
> This template-of-two-parameters is never used. Please remove it from this patch.
This was added [[ https://reviews.llvm.org/D96477?id=334360#inline-937744 | at your request ]]. Please confirm you understand what you're asking to be removed (or provide a technical argument explaining why it doesn't meet the conditions of your original request), and I'll remove it between libc++ approval and pushing to main.


================
Comment at: libcxx/test/std/concepts/concepts.callable/concept.equiv/equivalence_relation.subsumption.pass.cpp:51-53
+template<class F, class T, class U>
+requires std::equivalence_relation<F, T, U>
+[[nodiscard]] constexpr bool check_no_subsumption() { return false; }
----------------
Quuxplusone wrote:
> This template `check_no_subsumption` is never used. Please remove it from this patch.
In order for subsumption to be checked, one must have overloads to choose from. I've renamed it to `check_reverse_subsumption` instead of deleting.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96477/new/

https://reviews.llvm.org/D96477