[libcxx-commits] [PATCH] D96477: [libcxx] adds remaining callable concepts

Louis Dionne via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Apr 5 14:20:54 PDT 2021


ldionne added a comment.

LGTM with nitpick applied.

Until we enforce the use of clang-format, please consider format-related comments as non-blocking, unless not fixing them really hinders the readability of the code.



================
Comment at: libcxx/test/std/concepts/concepts.callable/concept.equiv/equivalence_relation.subsumption.pass.cpp:22
+
+template<class F, class T>
+requires std::equivalence_relation<F, T, T> && true
----------------
I agree, I think this can be removed since it's never used (unless I'm missing something).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96477/new/

https://reviews.llvm.org/D96477



More information about the libcxx-commits mailing list