[libcxx-commits] [PATCH] D88599: [SystemZ][ZOS] Porting pthread_t related functionality within libc++ to z/OS

[Zbigniew Sarbinowski via Phabricator via libcxx-commits]

zibi added inline comments.


================
Comment at: libcxx/include/__threading_support:495
 {
-  return pthread_equal(t1, t2) != 0;
+  return t1 == t2;
 }
----------------
mclow.lists wrote:
> This is what this code used to be. It's wrong, because `pthread_t` is not a type that we control, and there's no guarantee that it has an `operator==`.  That's why there's a call `pthread_equal`
> This is what this code used to be. It's wrong, because `pthread_t` is not a type that we control, and there's no guarantee that it has an `operator==`.  That's why there's a call `pthread_equal`


Thx Marshall, the problem with the original call to `'thread_equal` is that it was passing wrong parameters by mixing thread_id with thread_t. We need clear separation between them and don't use them interchangeably.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88599/new/

https://reviews.llvm.org/D88599