[libcxx-commits] [libcxx] 490b556 - [libc++] Make sure we don't attempt to run check-cxx-abilist when libc++ doesn't define new/delete

[Louis Dionne via libcxx-commits]

Author: Louis Dionne
Date: 2020-09-30T14:59:03-04:00
New Revision: 490b556a0f3c9daddd05651d945662b93b3b13b9

URL: https://github.com/llvm/llvm-project/commit/490b556a0f3c9daddd05651d945662b93b3b13b9
DIFF: https://github.com/llvm/llvm-project/commit/490b556a0f3c9daddd05651d945662b93b3b13b9.diff

LOG: [libc++] Make sure we don't attempt to run check-cxx-abilist when libc++ doesn't define new/delete

That would make the test fail spuriously because we don't generate
an ABI list for that configuration.

Added: 
    

Modified: 
    libcxx/lib/abi/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/libcxx/lib/abi/CMakeLists.txt b/libcxx/lib/abi/CMakeLists.txt
index 0fa3aacfb0e2..cf7457fe8123 100644
--- a/libcxx/lib/abi/CMakeLists.txt
+++ b/libcxx/lib/abi/CMakeLists.txt
@@ -22,7 +22,8 @@ if (EXISTS "${ABILIST_FILE}"
     AND ("${LIBCXX_CXX_ABI_LIBNAME}" STREQUAL "libcxxabi" OR
          (APPLE AND "${LIBCXX_CXX_ABI_LIBNAME}" STREQUAL "default"))
     AND NOT LIBCXX_ABI_UNSTABLE
-    AND LIBCXX_ENABLE_EXCEPTIONS)
+    AND LIBCXX_ENABLE_EXCEPTIONS
+    AND LIBCXX_ENABLE_NEW_DELETE_DEFINITIONS)
     add_custom_target(check-cxx-abilist
             ${SYMDIFF_EXE} --only-stdlib-symbols --strict ${ABILIST_FILE}
             $<TARGET_SONAME_FILE:cxx_shared>