[libcxx-commits] [PATCH] D88599: [SystemZ][ZOS] Porting pthread_t related functionality within libc++ to z/OS

Marshall Clow via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Wed Sep 30 11:04:53 PDT 2020


mclow.lists requested changes to this revision.
mclow.lists added inline comments.
This revision now requires changes to proceed.


================
Comment at: libcxx/include/__threading_support:495
 {
-  return pthread_equal(t1, t2) != 0;
+  return t1 == t2;
 }
----------------
This is what this code used to be. It's wrong, because `pthread_t` is not a type that we control, and there's no guarantee that it has an `operator==`.  That's why there's a call `pthread_equal`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D88599/new/

https://reviews.llvm.org/D88599



More information about the libcxx-commits mailing list