[libcxx-commits] [PATCH] D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr

[Louis Dionne via Phabricator via libcxx-commits]

ldionne added a comment.

In D82490#2156438 <https://reviews.llvm.org/D82490#2156438>, @oontvoo wrote:

> > ! In D82490#2155964 <https://reviews.llvm.org/D82490#2155964>, @ldionne wrote:
> >  `-DLIBCXX_ABI_UNSTABLE=ON`?
>
> Hmm, I would've assumed it shouldn't matter ( in the CMakeCache.txt file, there's an assortment of `ON`, `OFF`, `FALSE` and `TRUE` for the `BOOL` flags)
>  But doesn't hurt to check.


I'm just not 100% sure CMake handles lowercase `true` as a `ON` value. It probably does.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82490/new/

https://reviews.llvm.org/D82490