[libcxx-commits] [PATCH] D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr

Thu Jul 16 11:53:46 PDT 2020

smeenai added a comment.

In D82490#2156440 <https://reviews.llvm.org/D82490#2156440>, @ldionne wrote:

> In D82490#2156438 <https://reviews.llvm.org/D82490#2156438>, @oontvoo wrote:
>
> > > ! In D82490#2155964 <https://reviews.llvm.org/D82490#2155964>, @ldionne wrote:
> > >  `-DLIBCXX_ABI_UNSTABLE=ON`?
> >
> > Hmm, I would've assumed it shouldn't matter ( in the CMakeCache.txt file, there's an assortment of `ON`, `OFF`, `FALSE` and `TRUE` for the `BOOL` flags)
> >  But doesn't hurt to check.
>
>
> I'm just not 100% sure CMake handles lowercase `true` as a `ON` value. It probably does.

Yup, it works either way. From https://cmake.org/cmake/help/latest/command/if.html#condition-syntax:

> True if the constant is 1, ON, YES, TRUE, Y, or a non-zero number. False if the constant is 0, OFF, NO, FALSE, N, IGNORE, NOTFOUND, the empty string, or ends in the suffix -NOTFOUND. Named boolean constants are case-insensitive.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82490/new/

https://reviews.llvm.org/D82490