[libcxx-commits] [PATCH] D82490: [libcxx] Put clang::trivial_abi on std::unique_ptr

[Vy Nguyen via Phabricator via libcxx-commits]

oontvoo added a comment.

> ! In D82490#2155964 <https://reviews.llvm.org/D82490#2155964>, @ldionne wrote:
>  `-DLIBCXX_ABI_UNSTABLE=ON`?

Hmm, I would've assumed it shouldn't matter ( in the CMakeCache.txt file, there's an assortment of `ON`, `OFF`, `FALSE` and `TRUE` for the `BOOL` flags)
But doesn't hurt to check.

  $ cmake -DLIBCXX_ABI_UNSTABLE=ON -DCMAKE_C_COMPILER=clang    -DCMAKE_CXX_COMPILER=clang++     -DLLVM_ENABLE_PROJECTS="libcxx;libcxxabi"  ../llvm
  <....clipped ...>
  $ make check-cxx
  <...... clipped ....>
  Testing Time: 751.38s
    Unsupported      :  182
    Passed           : 6138
    Expectedly Failed:   72


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D82490/new/

https://reviews.llvm.org/D82490