[libcxx-commits] [PATCH] D73525: [CMake][libcxx] Don't wrap __config_site path in quotes on Windows

Shoaib Meenai via Phabricator via libcxx-commits libcxx-commits at lists.llvm.org
Mon Jan 27 19:49:00 PST 2020


smeenai added inline comments.
Herald added a reviewer: mclow.lists.


================
Comment at: libcxx/CMakeLists.txt:877
     if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC" OR "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
-      target_compile_options(${target} PUBLIC "/FI\"${site_config_path}\"")
+      target_compile_options(${target} PUBLIC "/FI${site_config_path}")
     else()
----------------
```
      target_compile_options(${target} PUBLIC /FI "${site_config_path}")
```

is more consistent with the below case, if it works.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73525/new/

https://reviews.llvm.org/D73525





More information about the libcxx-commits mailing list