[libcxx-commits] [PATCH] D73525: [CMake][libcxx] Don't wrap __config_site path in quotes on Windows

[Petr Hosek via Phabricator via libcxx-commits]

phosek created this revision.
phosek added a reviewer: ldionne.
Herald added subscribers: libcxx-commits, dexonsmith, christof, mgorny.
Herald added a reviewer: EricWF.
Herald added a project: libc++.

This is failing to compile on Windows because clang-cl is trying to
use the path with quotes, dropping them resolves the issue.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D73525

Files:
  libcxx/CMakeLists.txt


Index: libcxx/CMakeLists.txt
===================================================================
--- libcxx/CMakeLists.txt
+++ libcxx/CMakeLists.txt
@@ -874,7 +874,7 @@
 function(cxx_add_config_site target)
   if (LIBCXX_NEEDS_SITE_CONFIG)
     if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC" OR "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
-      target_compile_options(${target} PUBLIC "/FI\"${site_config_path}\"")
+      target_compile_options(${target} PUBLIC "/FI${site_config_path}")
     else()
       target_compile_options(${target} PUBLIC -include "${site_config_path}")
     endif()


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73525.240758.patch
Type: text/x-patch
Size: 592 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20200128/c0098728/attachment.bin>