[libcxx-commits] [PATCH] D73525: [CMake][libcxx] Don't wrap __config_site path in quotes on Windows

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added inline comments.
This revision is now accepted and ready to land.


================
Comment at: libcxx/CMakeLists.txt:877
     if("${CMAKE_CXX_COMPILER_ID}" STREQUAL "MSVC" OR "${CMAKE_CXX_SIMULATE_ID}" STREQUAL "MSVC")
-      target_compile_options(${target} PUBLIC "/FI\"${site_config_path}\"")
+      target_compile_options(${target} PUBLIC "/FI${site_config_path}")
     else()
----------------
smeenai wrote:
> ```
>       target_compile_options(${target} PUBLIC /FI "${site_config_path}")
> ```
> 
> is more consistent with the below case, if it works.
Either way works for me. @phosek Please try using this suggestion, otherwise commit as-is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73525/new/

https://reviews.llvm.org/D73525