[libcxx-commits] [PATCH] D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages

[Martin Storsjö via Phabricator via libcxx-commits]

mstorsjo added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/class.path/path.member/path.charconv.pass.cpp:42
+// libstdc++ doesn't define conversions from/to wchar_t outside of windows.
+#if defined(_WIN32) || !defined(__GLIBCXX__)
+#define HAVE_WCHAR
----------------
ldionne wrote:
> I think this would read better if you used this instead:
> 
> ```
> #if defined(__GLIBCXX__) && !defined(_WIN32)
> #  define HAS_NO_WCHAR
> #endif
> ```
> 
> WDYT?
Sounds good to me, will change it that way


================
Comment at: libcxx/test/std/input.output/filesystems/class.path/path.member/path.charconv.pass.cpp:88
+  }
+#if TEST_STD_VER > 17 && defined(__cpp_char8_t)
+  {
----------------
mclow.lists wrote:
> This should be `__cpp_lib_char8_t`, because we're using a library facility
Thanks, will change that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91133/new/

https://reviews.llvm.org/D91133