[libcxx-commits] [PATCH] D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages
Martin Storsjö via Phabricator via libcxx-commits
libcxx-commits at lists.llvm.org
Thu Dec 3 11:21:52 PST 2020
mstorsjo added inline comments.
Comment at: libcxx/test/std/input.output/filesystems/class.path/path.member/path.charconv.pass.cpp:88
+#if TEST_STD_VER > 17 && defined(__cpp_char8_t)
> mclow.lists wrote:
> > This should be `__cpp_lib_char8_t`, because we're using a library facility
> Thanks, will change that.
I changed the other ifdefs to check `__cpp_lib_char8_t` as well. While they guard plain char8_t array definitions, they must be in sync with what type `path::u8string()` returns.
CHANGES SINCE LAST ACTION
More information about the libcxx-commits