[libcxx-commits] [PATCH] D91133: [2/N] [libcxx] [test] Add a test for conversions between wchar_t, utf8, char16_t, char32_t and windows native narrow code pages

[Marshall Clow via Phabricator via libcxx-commits]

mclow.lists added inline comments.


================
Comment at: libcxx/test/std/input.output/filesystems/class.path/path.member/path.charconv.pass.cpp:88
+  }
+#if TEST_STD_VER > 17 && defined(__cpp_char8_t)
+  {
----------------
This should be `__cpp_lib_char8_t`, because we're using a library facility


================
Comment at: libcxx/test/std/input.output/filesystems/class.path/path.member/path.charconv.pass.cpp:335
+
+#if TEST_STD_VER > 17 && defined(__cpp_char8_t)
+  {
----------------
`__cpp_lib_char8_t` here too.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91133/new/

https://reviews.llvm.org/D91133