[libcxx-commits] [PATCH] D62874: Fix libc++'s lit configuration language dialect inference for GCC 5 and GCC 6

[Louis Dionne via Phabricator via libcxx-commits]

ldionne accepted this revision.
ldionne added a comment.
This revision is now accepted and ready to land.

I'm okay with this (I don't care much about GCC), but I want to point out you're basically reducing the usefulness of the test suite on GCC 5/6 by just wholesale removing all C++17 tests, when GCC5/6 can actually run a large subset of the tests.

I think this is still better than adding a bunch of complexity to disable tests in a finer-grained manner.

Do you have commit access?


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62874/new/

https://reviews.llvm.org/D62874