[libcxx-commits] [PATCH] D62874: Fix libc++'s lit configuration language dialect inference for GCC 5 and GCC 6

[Bryce Adelstein Lelbach via Phabricator via libcxx-commits]

wash created this revision.
wash added reviewers: mclow.lists, ldionne, EricWF.
Herald added subscribers: libcxx-commits, dexonsmith, christof.

libc++'s lit configuration infers the C++ language dialect when it is not provided by checking which `-std=` flags that a compiler supports. GCC 5 and GCC 6 have a `-std=c++17` flag, however, they do not have full C++17 support. The lit configuration has hardcoded logic that removes `-std=c++1z` as an option to test for GCC < 7, but not `-std=c++17`.

This leads to a bunch of failures when running libc++ tests with GCC 5 or GCC 6.

This patch adds `-std=c++17` to the list of flags that are discarded for GCC < 7 by lit's language dialect inference.


Repository:
  rCXX libc++

https://reviews.llvm.org/D62874

Files:
  utils/libcxx/test/config.py


Index: utils/libcxx/test/config.py
===================================================================
--- utils/libcxx/test/config.py
+++ utils/libcxx/test/config.py
@@ -524,6 +524,7 @@
                 maj_v = int(maj_v)
                 if maj_v < 7:
                     possible_stds.remove('c++1z')
+                    possible_stds.remove('c++17')
                 # FIXME: How many C++14 tests actually fail under GCC 5 and 6?
                 # Should we XFAIL them individually instead?
                 if maj_v <= 6:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D62874.203002.patch
Type: text/x-patch
Size: 530 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/libcxx-commits/attachments/20190604/bf716c6b/attachment.bin>