[libcxx-commits] [PATCH] D62874: Fix libc++'s lit configuration language dialect inference for GCC 5 and GCC 6

[Bryce Adelstein Lelbach via Phabricator via libcxx-commits]

wash added a comment.

In D62874#1529811 <https://reviews.llvm.org/D62874#1529811>, @ldionne wrote:

> I'm okay with this (I don't care much about GCC), but I want to point out you're basically reducing the usefulness of the test suite on GCC 5/6 by just wholesale removing all C++17 tests, when GCC5/6 can actually run a large subset of the tests.


I see your point, but I think it was always the intention to disable these tests universally for GCC < 7 (thus the removal of `-std=c++1z`). Also, we do the same thing for C++14 tests for GCC5 - none of them run for GCC < 6.

The C++17 language support chart <https://gcc.gnu.org/projects/cxx-status.html#cxx17> for GCC is pretty sparse until GCC 7.

I thought about going through the failures individually, but there's about 150 with GCC 5.

> I think this is still better than adding a bunch of complexity to disable tests in a finer-grained manner.

Agreed.

> Do you have commit access?

Probably not.


Repository:
  rCXX libc++

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D62874/new/

https://reviews.llvm.org/D62874