[PATCH] D52240: Partial Fix for PR#38964

Zhihao Yuan via Phabricator reviews at reviews.llvm.org
Fri Sep 21 14:00:46 PDT 2018

lichray added a comment.

In https://reviews.llvm.org/D52240#1242536, @dim wrote:

> >   Symbol added: __ZNSt3__16__itoa8__u32toaEjPc
> >       {'type': 'FUNC', 'is_defined': True, 'name': '__ZNSt3__16__itoa8__u32toaEjPc'}
> >   
> >   Symbol added: __ZNSt3__16__itoa8__u64toaEyPc
> >       {'type': 'FUNC', 'is_defined': True, 'name': '__ZNSt3__16__itoa8__u64toaEyPc'}
> > 
> > 
> > So I assume the ABI is already broken in some way...
> This appears to be a consequence of https://reviews.llvm.org/rL338479 by @lichray , but since it only *adds* two functions, it might be harmless...

Yes, I don't have a Mac to test so I'm reluctant to add those symbols when committing.  Anyone who have a Mac can just add it.


More information about the libcxx-commits mailing list