[PATCH] D51868: [libcxx] Build and test fixes for Windows

Saleem Abdulrasool via Phabricator reviews at reviews.llvm.org
Tue Sep 18 15:31:31 PDT 2018

compnerd added inline comments.
Herald added a subscriber: libcxx-commits.

Comment at: include/filesystem:1396
   void __create_what(int __num_paths);
This possibly changes the meaning on other targets.  What was the error that this triggered?

Comment at: test/support/test_macros.h:147
-#  elif defined(_WIN32)
-#    if defined(_MSC_VER) && !defined(__MINGW32__)
-#      define TEST_HAS_C11_FEATURES // Using Microsoft's C Runtime library
I think that the condition here is inverted, and should be enabled for MinGW32.

  rCXX libc++


More information about the libcxx-commits mailing list