[PATCH] D52240: Partial Fix for PR#38964

[Dimitry Andric via Phabricator]

dim added a subscriber: lichray.
dim added a comment.

In https://reviews.llvm.org/D52240#1242341, @dim wrote:

> Hmm, I tried on macOS 10.13.6 with Xcode 9.4.1 and Apple LLVM version 9.1.0 (clang-902.0.39.2), using stock libc++ r342744, but that already failed:
>
>   ninja: Entering directory `/Users/dim/obj/llvm-342744-trunk-darwin17-x86_64-ninja-rel-1'
>   [1/1] Testing ABI compatibility...
>   FAILED: projects/libcxx/lib/abi/CMakeFiles/check-cxx-abilist
>   cd /Users/dim/obj/llvm-342744-trunk-darwin17-x86_64-ninja-rel-1/projects/libcxx/lib/abi && /Users/dim/tmp/llvm/projects/libcxx/utils/sym_diff.py --only-stdlib-symbols --strict /Users/dim/tmp/llvm/projects/libcxx/lib/abi/x86_64-apple-darwin.v1.abilist /Users/dim/obj/llvm-342744-trunk-darwin17-x86_64-ninja-rel-1/lib/libc++.1.dylib
>   Symbol added: __ZNSt3__16__itoa8__u32toaEjPc
>       {'type': 'FUNC', 'is_defined': True, 'name': '__ZNSt3__16__itoa8__u32toaEjPc'}
>  
>   Symbol added: __ZNSt3__16__itoa8__u64toaEyPc
>       {'type': 'FUNC', 'is_defined': True, 'name': '__ZNSt3__16__itoa8__u64toaEyPc'}
>  
>   Summary
>       Added:   2
>       Removed: 0
>       Changed: 0
>   Symbols added.
>
>
> So I assume the ABI is already broken in some way...


This appears to be a consequence of https://reviews.llvm.org/rL338479 by @lichray , but since it only *adds* two functions, it might be harmless...


https://reviews.llvm.org/D52240