[PATCH] D52240: Partial Fix for PR#38964

Dimitry Andric via Phabricator reviews at reviews.llvm.org
Fri Sep 21 11:55:31 PDT 2018

dim added a subscriber: emaste.
dim added a comment.

In https://reviews.llvm.org/D52240#1239509, @ldionne wrote:

> Marshall, can you confirm that the change does not break `check-cxx-abilist` on OS X. I'm fine with the change if that's not broken.

Hmm, I tried on macOS 10.13.6 with Xcode 9.4.1 and Apple LLVM version 9.1.0 (clang-902.0.39.2), using stock libc++ r342744, but that already failed:

  ninja: Entering directory `/Users/dim/obj/llvm-342744-trunk-darwin17-x86_64-ninja-rel-1'
  [1/1] Testing ABI compatibility...
  FAILED: projects/libcxx/lib/abi/CMakeFiles/check-cxx-abilist
  cd /Users/dim/obj/llvm-342744-trunk-darwin17-x86_64-ninja-rel-1/projects/libcxx/lib/abi && /Users/dim/tmp/llvm/projects/libcxx/utils/sym_diff.py --only-stdlib-symbols --strict /Users/dim/tmp/llvm/projects/libcxx/lib/abi/x86_64-apple-darwin.v1.abilist /Users/dim/obj/llvm-342744-trunk-darwin17-x86_64-ninja-rel-1/lib/libc++.1.dylib
  Symbol added: __ZNSt3__16__itoa8__u32toaEjPc
      {'type': 'FUNC', 'is_defined': True, 'name': '__ZNSt3__16__itoa8__u32toaEjPc'}
  Symbol added: __ZNSt3__16__itoa8__u64toaEyPc
      {'type': 'FUNC', 'is_defined': True, 'name': '__ZNSt3__16__itoa8__u64toaEyPc'}
      Added:   2
      Removed: 0
      Changed: 0
  Symbols added.

So I assume the ABI is already broken in some way...

But on a more positive note, applying this review did not change the `check-cxx-abilist` output, so I guess for macOS it should be okay?

@emaste we should really try to also get the `check-cxx-abilist` target working for FreeBSD!


More information about the libcxx-commits mailing list