[PATCH] D51868: [libcxx] Build and test fixes for Windows

Stephan T. Lavavej via Phabricator reviews at reviews.llvm.org
Tue Sep 18 21:01:52 PDT 2018

STL_MSFT added inline comments.

Comment at: test/support/test_macros.h:147
-#  elif defined(_WIN32)
-#    if defined(_MSC_VER) && !defined(__MINGW32__)
-#      define TEST_HAS_C11_FEATURES // Using Microsoft's C Runtime library
compnerd wrote:
> I think that the condition here is inverted, and should be enabled for MinGW32.
What error prompted this? It hasn't caused problems when running libc++'s tests against MSVC's STL (with both C1XX and Clang).

  rCXX libc++


More information about the libcxx-commits mailing list